Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #441- Fix files are not working #455

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

ChanghyeonYoon
Copy link
Contributor

#441 Add spaceId to src for files(audio, file, video...)

@ChanghyeonYoon
Copy link
Contributor Author

ChanghyeonYoon commented Mar 23, 2023

@transitive-bullshit plz confirm :)

remove console
@vercel
Copy link

vercel bot commented Mar 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-notion-x ✅ Ready (Inspect) Visit Preview Mar 23, 2023 at 3:41AM (UTC)
react-notion-x-minimal-demo ✅ Ready (Inspect) Visit Preview Mar 23, 2023 at 3:41AM (UTC)

@MartinXPN
Copy link
Contributor

@transitive-bullshit Do you think this is a good fix to resolve the issues with the new notion file format for assets like video/audio? (#428 #449 #441 )

cc @normdoow @pbteja1998

@rimonhanna
Copy link
Contributor

@transitive-bullshit this one as well :)

@transitive-bullshit
Copy link
Member

Thanks @ChanghyeonYoon 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants