Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty group title for board view #477

Merged

Conversation

junogueira
Copy link
Contributor

@junogueira junogueira commented Apr 29, 2023

Description

Fix title for empty group on board view, using the property name instead of a static title.

Example

Board view grouped by Priority property:

Before
Screenshot 2023-04-29 at 19 56 03

After
Screenshot 2023-04-29 at 19 55 43

Notion Test Page ID

16f256fbf9b54bc6b4befe13ba74faeb

@vercel
Copy link

vercel bot commented Apr 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
react-notion-x ✅ Ready (Inspect) Visit Preview Jun 18, 2023 9:52pm
react-notion-x-minimal-demo ✅ Ready (Inspect) Visit Preview Jun 18, 2023 9:52pm

<EmptyIcon className='notion-board-th-empty' /> No
Select
<EmptyIcon className='notion-board-th-empty' />
{`No ${schema.name}` || 'No Select'}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you are missing the check for schema.name, what this will render if schema.name is not available?

Your provided No Select optional fallback does not work here.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @s4nju and @transitive-bullshit, it should be fixed now.

@transitive-bullshit
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants