Update node version to 18.X to fix ky universal build issues #573
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR builds on top of #568. That PR should be merged first so that we get smaller overall changes.
Root cause
After @transitive-bullshit replaced
got
forky
#394 our builds broke down with following issue:I noticed that the
ky-universal
is not needed anymore if we updateky
to1.0.0
and nodejs to version18.X
version.Consequences and why we need to add tsimp
After I upgraded them our tests started to fail in all packages:
I wasn't able to figure out this on my own but I was using the cursor editor and it suggested adding
tsimp
as loader forava
and then the tests started to work.We can't use the latest version of
tsimp
so it's pinned to 2.0.11.It can be updated when we get node 18 support.