Add support for Table columns & headers #592
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
wustep
commented
Nov 25, 2024
| @@ -13,6 +13,8 @@ | |||
| --fg-color-7: rgba(55, 53, 47, 0.5); | |||
| --fg-color-icon: var(--fg-color); | |||
|
|
|||
| --divider: rgb(233, 233, 231); | |||
There was a problem hiding this comment.
This new divider var is introduced because..
- the color was previously wrong and too faint. this color is lifted directly from notion
- If you use a color with an alpha, this leads to stacking for both row + column color configs, or adjusting based on background color (e.g. in a callout)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now, react-notion-x assumes that the first row is always the header, but in Notion you can customize either:
This adds support for these, removing the default first-row-as-header.
Notion Test Page ID
https://www.notion.so/wustep/Tables-1495cb08cf2c804f977af6108cbd4fc8
before
localhost w/ changes vs notion prod