Only DeleteOnClose when running under Windows for global lock #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
|
||
| // Assert | ||
| Assert.Equal(threads * iterations, results.Length); | ||
| foreach (var result in results) |
There was a problem hiding this comment.
Assert.DoesNotContain(false, results)
|
🆒 |
|
|
joelverhagen
force-pushed
the
jver-fixlock
branch
2 times, most recently
from
a7fc20d
to
42be446
Compare
| var acquired = await verificationSemaphore.WaitAsync(0); | ||
| if (!acquired) | ||
| { | ||
| throw new Exception("The semaphore could not be acquired, meaning the locking mechanism is not working."); |
There was a problem hiding this comment.
Don't throw Exception ever, not even in a test
There was a problem hiding this comment.
Sure, I can return false here, although it seems like throwing exceptions in tests can be useful sometimes.
joelverhagen
force-pushed
the
jver-fixlock
branch
from
42be446
to
1d73fdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FileOptions.DeleteOnClosewhen running under Windows when opening the global lockFileStream. We need to come up with a cleanup story for the other platforms.@emgarten @yishaigalatzer @stephentoub @zhili1208 @alpaix