Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed password encryption and decryption error message #671

Merged
merged 1 commit into from
Jun 10, 2016

Conversation

zhili1208
Copy link
Contributor

@joelverhagen
Copy link
Member

Please consider merging to dev, so that people upgrading from 3.5.0-beta2 to 3.5.0-rtm (or whatever) don't see this message regress.

@@ -151,10 +151,10 @@
<value>Unexpected failure reading NuGet.Config. Path: '{0}'.</value>
</data>
<data name="UnsupportedDecryptPassword" xml:space="preserve">
<value>Password decryption failed for source : '{0}' is unsupported on this platform. A clear text password may be used instead.</value>
<value>Password decryption is not supported on this platform (Windows/.NET Core). The following feed uses an encrypted password: '{0}'. You can use a clear text password as a workaround, or pass it on the commandline</value>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: sentence should end in a period (.).

@joelverhagen
Copy link
Member

Address comment and :shipit:

@zhili1208 zhili1208 force-pushed the ErrorMessageChanging branch from 2922412 to 7e6b473 Compare June 10, 2016 18:15
@zhili1208 zhili1208 merged commit 7e6b473 into release-3.5.0-beta2 Jun 10, 2016
@alpaix
Copy link
Contributor

alpaix commented Jun 10, 2016

Message is deceiving. Interactive password is not supported on .NET Core. Encrypted passwords are not supported on all platforms not just Windows.

@zhili1208 zhili1208 deleted the ErrorMessageChanging branch June 14, 2016 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants