Pr 10173 #10204
Closed
Pr 10173 #10204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Markdig supports alert blocks as documented at https://github.com/xoofx/markdig/blob/master/src/Markdig.Tests/Specs/AlertBlockSpecs.md. Bumping markdig and adding `.UseAlertBlocks()` now renders the expected html. Not sure how to go about adding the styles as needed. Partial fix for #10125
Markdig supports alert blocks as documented at https://github.com/xoofx/markdig/blob/master/src/Markdig.Tests/Specs/AlertBlockSpecs.md. Bumping markdig and adding `.UseAlertBlocks()` now renders the expected html. Fixes #10125
If we don't unset it, the default bootstrap p style turns dark mode illegible (uses white-ish color). This seems to be an issue specific to the very old version of Bootstrap being used (v3.x). When running the site locally, I could not find any other .css (or .less) files being built or linked from the page, so I placed the only needed style in the only other style file other than bootstrap.
Markdig supports alert blocks as documented at https://github.com/xoofx/markdig/blob/master/src/Markdig.Tests/Specs/AlertBlockSpecs.md. Bumping markdig and adding `.UseAlertBlocks()` now renders the expected html. Fixes #10125
If we don't unset it, the default bootstrap p style turns dark mode illegible (uses white-ish color). This seems to be an issue specific to the very old version of Bootstrap being used (v3.x). When running the site locally, I could not find any other .css (or .less) files being built or linked from the page, so I placed the only needed style in the only other style file other than bootstrap.
|
This appears to be a duplicate of #10173. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes (in less than 80 characters):
Addresses #123