fix: still show feedback if no regions affected by cmd #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haykam821
reviewed
Jun 12, 2024
| } | ||
|
|
||
| return 2; |
There was a problem hiding this comment.
This isn't relevant to this pull request, but it's odd that this command has a result of 2.
src/main/java/xyz/nucleoid/creator_tools/command/MapMetadataCommand.java
Outdated
Show resolved
Hide resolved
Restioson
force-pushed
the
fix/show-feedback-when-none-changed
branch
from
f1b358e to
b567de1
Compare
Restioson
force-pushed
the
fix/show-feedback-when-none-changed
branch
from
b567de1 to
44dfe7f
Compare
haykam821
reviewed
Jun 16, 2024
| @@ -47,6 +47,7 @@ | |||
| "text.nucleoid_creator_tools.map.open.map_already_exists": "Map with id '%s' already exists!", | |||
| "text.nucleoid_creator_tools.map.open.success": "Opened workspace '%s'! Use %s to join this map", | |||
| "text.nucleoid_creator_tools.map.origin.set": "Updated origin for workspace", | |||
| "text.nucleoid_creator_tools.map.region.none_affected": "No regions affected.", | |||
There was a problem hiding this comment.
Nit: this key should be sorted after text.nucleoid_creator_tools.map.region.entity.remove.success.
There was a problem hiding this comment.
Why particularly? That is for entity removal, and this is for any kind of region processing (e.g. remove, data get, merge, etc)
Gegy
approved these changes
Jun 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just shows a little bit of feedback if no regions were matched, to improve QoL