Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text shown on game portal signs should be vertically centered #263

Closed
haykam821 opened this issue Jan 21, 2023 · 0 comments · Fixed by #284
Closed

Text shown on game portal signs should be vertically centered #263

haykam821 opened this issue Jan 21, 2023 · 0 comments · Fixed by #284

Comments

@haykam821
Copy link
Contributor

Right now, text is shown on the first and second lines of game portal signs:

if (line == 0) {
var name = display.get(GamePortalDisplay.NAME);
if (name != null) {
return name;
}
} else if (line == 1) {
var playerCount = display.get(GamePortalDisplay.PLAYER_COUNT);
if (playerCount != null) {
return Text.translatable("text.plasmid.game.portal.player_count", playerCount);
}
}

Since signs support four lines in total, the text should be shown on the second and third lines instead.

@haykam821 haykam821 changed the title Text shown on game portal signs should be centered Text shown on game portal signs should be vertically centered Nov 13, 2023
haykam821 added a commit to haykam821/plasmid that referenced this issue Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant