Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include license file in published crates #47

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

ankane
Copy link
Contributor

@ankane ankane commented Nov 21, 2024

Hi, thanks for this project! This symlinks the license file so it's included in the published crates.

@ankane ankane changed the title Include license files in published crates Include license file in published crates Nov 21, 2024
@Nugine
Copy link
Owner

Nugine commented Nov 22, 2024

Thanks! Is there any background for this PR?
The license in Cargo.toml is license = "MIT". Previously I thought it was enough for license checkers.

@ankane
Copy link
Contributor Author

ankane commented Nov 22, 2024

Hi @Nugine, the MIT license mentions including it with copies of the software, and it's nice for things like cargo vendor (microsoft/windows-rs#1587 (comment)).

@Nugine Nugine merged commit c654022 into Nugine:main Nov 22, 2024
7 of 8 checks passed
@Nugine
Copy link
Owner

Nugine commented Nov 22, 2024

v0.9 is now waiting for #46 .
Do you need a patch version v0.8.1 with this PR backported?

@ankane
Copy link
Contributor Author

ankane commented Nov 22, 2024

Thanks @Nugine! No need to backport (I can include it manually) - just thought it'd be good for future releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants