Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor client #608

Merged
merged 6 commits into from
Feb 11, 2025
Merged

Refactor client #608

merged 6 commits into from
Feb 11, 2025

Conversation

Nukesor
Copy link
Owner

@Nukesor Nukesor commented Feb 11, 2025

Just rewrite everything

@Nukesor Nukesor added t: Enhancement Something that exists, but could be made better s: Pueue-lib This issue touches the pueue-lib library s: Client This issue touches the pueue client labels Feb 11, 2025
@Nukesor Nukesor self-assigned this Feb 11, 2025
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 73.49103% with 325 lines in your changes missing coverage. Please review.

Project coverage is 80.21%. Comparing base (aa19740) to head (2af2bc5).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
pueue/src/client/commands/mod.rs 62.65% 62 Missing ⚠️
pueue/src/client/commands/state/mod.rs 76.25% 52 Missing ⚠️
pueue/src/client/commands/follow.rs 83.07% 22 Missing ⚠️
pueue/src/client/commands/reset.rs 0.00% 22 Missing ⚠️
pueue/src/client/commands/kill.rs 0.00% 19 Missing ⚠️
pueue/src/client/commands/parallel.rs 0.00% 18 Missing ⚠️
pueue/src/client/commands/state/query/mod.rs 94.11% 18 Missing ⚠️
pueue/src/client/commands/stash.rs 0.00% 17 Missing ⚠️
pueue/src/client/commands/pause.rs 0.00% 16 Missing ⚠️
pueue/src/client/commands/clean.rs 0.00% 14 Missing ⚠️
... and 11 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #608      +/-   ##
==========================================
- Coverage   80.34%   80.21%   -0.13%     
==========================================
  Files          78       89      +11     
  Lines        6018     6348     +330     
==========================================
+ Hits         4835     5092     +257     
- Misses       1183     1256      +73     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Test Results

  3 files  ± 0   19 suites  ±0   3m 29s ⏱️ +3s
174 tests ± 0  174 ✅ ± 0  0 💤 ±0  0 ❌ ±0 
394 runs  +28  394 ✅ +28  0 💤 ±0  0 ❌ ±0 

Results for commit 2af2bc5. ± Comparison against base commit aa19740.

This pull request removes 28 and adds 28 tests. Note that renamed tests count towards both.
pueue::tests ‑ client::unit::status_query::column_selection
pueue::tests ‑ client::unit::status_query::filter_command::case_1
pueue::tests ‑ client::unit::status_query::filter_command::case_2
pueue::tests ‑ client::unit::status_query::filter_command::case_3
pueue::tests ‑ client::unit::status_query::filter_command::case_4
pueue::tests ‑ client::unit::status_query::filter_command::case_5
pueue::tests ‑ client::unit::status_query::filter_command::case_6
pueue::tests ‑ client::unit::status_query::filter_command::case_7
pueue::tests ‑ client::unit::status_query::filter_command::case_8
pueue::tests ‑ client::unit::status_query::filter_end_with_time::case_1
…
pueue ‑ client::commands::state::query::test::column_selection
pueue ‑ client::commands::state::query::test::filter_command::case_1
pueue ‑ client::commands::state::query::test::filter_command::case_2
pueue ‑ client::commands::state::query::test::filter_command::case_3
pueue ‑ client::commands::state::query::test::filter_command::case_4
pueue ‑ client::commands::state::query::test::filter_command::case_5
pueue ‑ client::commands::state::query::test::filter_command::case_6
pueue ‑ client::commands::state::query::test::filter_command::case_7
pueue ‑ client::commands::state::query::test::filter_command::case_8
pueue ‑ client::commands::state::query::test::filter_end_with_time::case_1
…

@Nukesor Nukesor merged commit 8fa12bc into main Feb 11, 2025
18 of 19 checks passed
@Nukesor Nukesor deleted the refactor-client branch February 11, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s: Client This issue touches the pueue client s: Pueue-lib This issue touches the pueue-lib library t: Enhancement Something that exists, but could be made better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant