Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes some issues #673

Merged
merged 5 commits into from
Apr 18, 2019
Merged

Fixes some issues #673

merged 5 commits into from
Apr 18, 2019

Conversation

Ekultek
Copy link
Contributor

@Ekultek Ekultek commented Apr 18, 2019

  • Have to have the right version to create an issue
  • Changes the way that issue "identifiers" are created
  • Some minor fixes

adivinaelnombre and others added 3 commits April 14, 2019 22:25
… version it will not create an issue, also changes how the identifier is created
@Ekultek
Copy link
Contributor Author

Ekultek commented Apr 18, 2019

Also the docker stuff

@NullArray
Copy link
Owner

Thought i merged the docker stuff already? Anyway i'll add my review.

Docker/README.md Outdated Show resolved Hide resolved
Copy link
Owner

@NullArray NullArray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we getting rid of the README.md in the docker directory. I have referenced that in the main README, with regards to the docker compose stuff.

@NullArray
Copy link
Owner

If i am missing something, please let me know. It could be an oversight on my part but i'd like to make sure before i merge it into the master branch.

@Ekultek Ekultek requested a review from NullArray April 18, 2019 17:31
Copy link
Owner

@NullArray NullArray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing the issue. Approved and merged.

@NullArray NullArray merged commit 94677e7 into master Apr 18, 2019
@Ekultek
Copy link
Contributor Author

Ekultek commented Apr 18, 2019

<3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants