fix(addon-order): run esbuild before broccoli-asset-rev #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingerprinted correctly
NullVoxPopuli
force-pushed
the
test-addon-order
branch
from
4928255
to
2906e1b
Compare
NullVoxPopuli
commented
Dec 1, 2021
NullVoxPopuli
commented
Dec 1, 2021
| let app = await appJS(); | ||
| let vendor = await vendorJS(); | ||
|
|
||
| // fingerprint occurred |
There was a problem hiding this comment.
these are the new assertions -- and I also verified this manually via ember s and opening the inspector
NullVoxPopuli
commented
Dec 1, 2021
| "after": "broccoli-asset-rev" | ||
| "before": [ | ||
| "ember-cli-sri", | ||
| "broccoli-asset-rev" |
There was a problem hiding this comment.
this change is untested, but I believe this is the correct behavior
|
🎉 This PR is included in version 5.1.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: PR diff is big because I added an addon for testing fingerprinting (from broccoli-asset-rev) in vendor.js.
This is a weird issue, because there is clearly a problem somewhere in the ecosystem, but images not being fingerprinted with ember-cli-esbuild-minifer currently has no reproduction local to this repo.
I tried to re-create the scenario that causes images to not be fingerprinted when ember-cli-esbuild-minifier is present, but was unable to do so.
There are additional assertions added that at least ensure images are fingerprinted -- checking both app and vendor js.