Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed anonymous merge to reassign #9

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

rubeon
Copy link

@rubeon rubeon commented Apr 1, 2016

No description provided.

@Sliim
Copy link
Member

Sliim commented Apr 6, 2016

Hi,

thanks for your fix, but can you revert your latest 2 commits? Or recreate a PR from a specific branch in your fork please.
I will fix foodcritic & rubocop, do not take care to travis build failures.

Also, some serverspecs would be appreciated to valide your fix :)

Thx.

@rubeon
Copy link
Author

rubeon commented Apr 10, 2016

Thanks, I've reverted those commits -- sorry, wasn't intending them to be in the PR :-/

I'll work on testing coverage for it and send a later PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants