Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oauth2 rfc6749 requires TLS for authorization endpoint #1917

Closed
wants to merge 2 commits into from
Closed

oauth2 rfc6749 requires TLS for authorization endpoint #1917

wants to merge 2 commits into from

Conversation

AxelNennker
Copy link
Contributor

Signed-off-by: Axel Nennker axel.nennker@telekom.de

Referencing OAuth2 Authorization Endpoint
Since requests to the authorization endpoint result in user authentication and the transmission of clear-text credentials (in the HTTP response), the authorization server MUST require the use of TLS as described in Section 1.6 when sending requests to the authorization endpoint.

Changed the other http URLs to https as well because 'confidentiality' e.g. user information in some examples

Signed-off-by: Axel Nennker <axel.nennker@telekom.de>
@MikeRalphson
Copy link
Member

Thanks for the PR. As v3.0.2 is released, changes should go against the most recent patch version on the associated -dev branch.

You will see that a number of these changes have already been made in v3.0.3.

As to the meat of this change, I think we should note what users of the specification MUST do, and not what components of the oAuth dance MUST do, to make it clear we are not intending to make changes to the referenced RFC behaviour. I.e. something like "The authorization URL must specify a secure scheme" rather than "The authorization server MUST require the use of TLS."

Copy link
Member

@MikeRalphson MikeRalphson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per comments.

* Fix missing schema type in YAML example spec

* Moved type: object into allOf
@AxelNennker
Copy link
Contributor Author

Closing this as it is not based on the latest -dev branch.
Created new PR based on v3.1.0-dev
#1959

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants