-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OAS schema dialect clarifications #2399
Merged
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e5966fa
OAS schema dialect clarifications
MikeRalphson b57aed0
OAS schema dialect clarifications
MikeRalphson f51e2e7
$schema is allowed in subschemas when bundling
MikeRalphson c5eff97
Merge branch 'json-vocab' of https://github.com/MikeRalphson/OpenAPI-…
MikeRalphson 7b277cc
Schema dialect clarifications from Ben
MikeRalphson 8aa27b1
Use top-level jsonSchemaDialect field
MikeRalphson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something that just occurred to me due to the ongoing discussion about
discriminator
, particularly if theselectBy
idea is adopted: It might be better to putdiscriminator
in its own vocabulary since it is complex to implement and (particularly ifselectBy
were added) not strictly necessary.Putting it in its own vocabulary allows implementations to choose whether to implement it separately from the other OAS extension keywords, and could allow for dialect configurations that require the other OAS extension keywords but leave
discriminator
as optional. idk if that's really a great idea or not but thought I would mention it. We movedunevaluatedProperties
andunevaluatedItems
into their own vocabulary for similar reasons- they are complex and potentially expensive so some use cases might prefer not to deal with them (streaming implementations, for example, are much more costly with these).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We believe this issue is one that requires further conversation but don't believe it should hold up merging the current PR that introduces the dialect property.