-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
servers is an array of server #2526
Conversation
@SamiAkkawi Thanks for this! These schemas went through almost no testing at all and are probably full of bugs like these. Keep these PRs comming, but have a read through the README, especially this part
I prefer working with JSON as well, but around here it's YAML first. We make the change in the YAML file and then use the following to generate the JSON version.
If you have an OpenAPI document that exposed this bug, it would be great if you could add that to the tests in https://github.com/OAI/OpenAPI-Specification/tree/master/tests/v3.1 as well. If not, that's ok too. |
@jdesrosiers thank you for the clarifications. Changes done. |
@jdesrosiers quick question: do we know how long to pull request need to get accepted? Or Are there any specific dates to go through all open pull requests? Or how is that managed exactly? |
@SamiAkkawi I don't know exactly. I'll ask at the TSC meeting next week. |
@MikeRalphson putting this on your radar. |
* servers is an array of server * fix only yaml file * add servers test * update schema.json from shema.yaml
No description provided.