Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

servers is an array of server #2526

Merged
merged 4 commits into from
Apr 15, 2021
Merged

Conversation

sami-akkawi
Copy link
Contributor

No description provided.

@jdesrosiers
Copy link
Contributor

@SamiAkkawi Thanks for this! These schemas went through almost no testing at all and are probably full of bugs like these. Keep these PRs comming, but have a read through the README, especially this part

To submit improvements to the schema, modify the schema.yaml file only.

I prefer working with JSON as well, but around here it's YAML first. We make the change in the YAML file and then use the following to generate the JSON version.

./scripts/yaml2json/yaml2json.js schemas/v3.1/schema.yaml

If you have an OpenAPI document that exposed this bug, it would be great if you could add that to the tests in https://github.com/OAI/OpenAPI-Specification/tree/master/tests/v3.1 as well. If not, that's ok too.

@sami-akkawi
Copy link
Contributor Author

@jdesrosiers thank you for the clarifications. Changes done.

@sami-akkawi
Copy link
Contributor Author

@jdesrosiers quick question: do we know how long to pull request need to get accepted? Or Are there any specific dates to go through all open pull requests? Or how is that managed exactly?

@jdesrosiers
Copy link
Contributor

@SamiAkkawi I don't know exactly. I'll ask at the TSC meeting next week.

@philsturgeon
Copy link
Contributor

@MikeRalphson putting this on your radar.

@webron webron merged commit 54b0264 into OAI:master Apr 15, 2021
char0n pushed a commit to char0n/OpenAPI-Specification that referenced this pull request Jul 5, 2021
* servers is an array of server

* fix only yaml file

* add servers test

* update schema.json from shema.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants