Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy Versions section from 3.1.1-dev into 3.0.4-dev #3214

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Copy Versions section from 3.1.1-dev into 3.0.4-dev #3214

merged 1 commit into from
Feb 15, 2024

Conversation

ralfhandl
Copy link
Contributor

@ralfhandl ralfhandl commented Mar 24, 2023

Fixes #3195

Alternative to #3219

@ralfhandl
Copy link
Contributor Author

ralfhandl commented Mar 24, 2023

@darrelmiller @webron please review

@webron
Copy link
Member

webron commented Mar 24, 2023

Should have probably commented on the original issue. Given this is a patch version, I'm not convinced this is a change we should put in. The versioning scheme changed between 3.0 and 3.1. Changing the explanation because the patch version of 3.0 comes out after 3.1 was released doesn't require us to update that information. For 3.0, semver still holds.

@Saud96525
Copy link

إصلاحات # 3195

@ralfhandl
Copy link
Contributor Author

@webron I see your point and prepared an alternative fix that is in line with the semver statement in the first paragraph of the 3.0 Versions section.

#3219

@786aleee
Copy link

#3214

@handrews handrews added this to the v3.0.4 milestone Jan 27, 2024
@handrews handrews added the clarification requests to clarify, but not change, part of the spec label Jan 29, 2024
@darrelmiller
Copy link
Member

I am agreeing to this because it adds clarity to the impact on 3.0 descriptions post 3.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification requests to clarify, but not change, part of the spec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants