-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix JSON media type example #3434
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! These look straightforward. There is a bit of a process question to resolve regarding deployment, and also synchronizing JSON and YAML versions, see #3516 for tracking that sort of thing. EDIT: Never mind, I thought this was on the actual schema file, but this is an example in the 3.1.1-dev OAS itself, this can be merged whenever the @OAI/tsc approves.
@floitsch I just realized that while you got the branch right 🎉 this would need to be on the If you could update this to change |
Does this also need to go into 3.0.4? |
@floitsch I'm assuming that since it took us nearly 3 months to respond to this that you understandably aren't monitoring it now. I've re-submitted this on your behalf for both 3.1.1 (#3546) and 3.0.4 (#3547), retaining a credit to you in the commit. Please feel free to comment here if you'd rather re-submit yourself and just hadn't gotten around to it. Thank you for the contribution! |
I was a bit busy and only managed to look at it today. Nice surprise to see it already done :) No need for the attribution/credit. The important thing is that the code-base gets improved. |
No description provided.