Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSON media type example #3434

Closed
wants to merge 1 commit into from

Conversation

floitsch
Copy link

@floitsch floitsch commented Nov 5, 2023

No description provided.

Copy link
Member

@handrews handrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! These look straightforward. There is a bit of a process question to resolve regarding deployment, and also synchronizing JSON and YAML versions, see #3516 for tracking that sort of thing. EDIT: Never mind, I thought this was on the actual schema file, but this is an example in the 3.1.1-dev OAS itself, this can be merged whenever the @OAI/tsc approves.

@handrews
Copy link
Member

@floitsch I just realized that while you got the branch right 🎉 this would need to be on the versions/3.1.1.md file rather than the versions/3.1.0.md. We only update published specs for broken links (yes, it's been considered to update this sort of formatting error as well, but... there's a big conversation there and for now that is not the policy- we're still figuring out how to deploy the broken link fixes as allowing that change is a new policy).

If you could update this to change 3.1.1.md and not 3.1.0.md we'll be happy to merge it.

@handrews
Copy link
Member

Does this also need to go into 3.0.4?

@handrews handrews added this to the v3.1.1 milestone Jan 27, 2024
@handrews handrews added the examples requests for more or better examples in the specification label Jan 29, 2024
@handrews
Copy link
Member

handrews commented Feb 2, 2024

@floitsch I'm assuming that since it took us nearly 3 months to respond to this that you understandably aren't monitoring it now. I've re-submitted this on your behalf for both 3.1.1 (#3546) and 3.0.4 (#3547), retaining a credit to you in the commit. Please feel free to comment here if you'd rather re-submit yourself and just hadn't gotten around to it.

Thank you for the contribution!

@handrews handrews closed this Feb 2, 2024
@floitsch floitsch deleted the floitsch/fix-example branch February 4, 2024 09:11
@floitsch
Copy link
Author

floitsch commented Feb 4, 2024

@floitsch I'm assuming that since it took us nearly 3 months to respond to this that you understandably aren't monitoring it now. I've re-submitted this on your behalf for both 3.1.1 (#3546) and 3.0.4 (#3547), retaining a credit to you in the commit. Please feel free to comment here if you'd rather re-submit yourself and just hadn't gotten around to it.

I was a bit busy and only managed to look at it today. Nice surprise to see it already done :)

No need for the attribution/credit. The important thing is that the code-base gets improved.
Thanks for porting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples requests for more or better examples in the specification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants