-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds missing package lock for reproductible CI #3564
Conversation
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Note: the schema test will fail until we merge to main since there currently isn't any package-lock.json on main |
How does this change affect people running the checks locally? |
when you install locally, you'll get the same exact versions that were installed when this file was setup (or whenever a dependabot update was merged). It improves reproducibility |
on the first pull after this gets merged however, you might have git complaining that you already have a package-lock.json if you've already ran |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After some discussion last week, this sort of limited-impact change (most of our checks are failing right now anyway) can be merged with one approval, so I'm doing that. |
fixes #3556