Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify openIdConnectUrl #3630 #3718

Merged
merged 3 commits into from
May 1, 2024
Merged

Clarify openIdConnectUrl #3630 #3718

merged 3 commits into from
May 1, 2024

Conversation

m-mohr
Copy link
Contributor

@m-mohr m-mohr commented Apr 19, 2024

Clarification according to openIdConnectUrl as discussed in #3630

@handrews handrews added this to the v3.1.1 milestone Apr 20, 2024
@handrews handrews added the clarification requests to clarify, but not change, part of the spec label Apr 22, 2024
@AxelNennker
Copy link
Contributor

I think this PR improves the spec. I approve - modulo which version this should go into. Personally I would backport this clarification to when openIdConnectUrl was introduced.

versions/3.1.1.md Outdated Show resolved Hide resolved
@m-mohr m-mohr requested a review from lornajane April 25, 2024 19:54
@ralfhandl
Copy link
Contributor

ralfhandl commented Apr 26, 2024

@lornajane The text cited from the referenced spec was removed, instead "well-known" is now part of the link text.

I think that matches the spirit of the requested change, please confirm.

Copy link
Contributor

@AxelNennker AxelNennker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the text should be like the oauth2MetadataUrl text in version 3.2

versions/3.1.1.md Outdated Show resolved Hide resolved
Copy link
Contributor

@lornajane lornajane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good clarification for this existing field, thank you.

@lornajane lornajane merged commit 88b199d into OAI:v3.1.1-dev May 1, 2024
1 check passed
@m-mohr m-mohr deleted the patch-2 branch May 1, 2024 08:37
@m-mohr
Copy link
Contributor Author

m-mohr commented May 1, 2024

How is this going to be made available in 3.2.0?

@handrews
Copy link
Member

handrews commented May 1, 2024

@m-mohr someone needs to copy the fix over to the versions/3.2.0.md file on the v3.2.0-dev branch. If you have time to do it, that would be most appreciated! If not, we'll audit the branches at some point to reconcile. (starting with 3.2, we will be moving to a more normal use of git branches of a single spec file).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification requests to clarify, but not change, part of the spec security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants