Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify how to model binary data (3.2.0 port of #3727 and #3729 #3770

Merged
merged 2 commits into from
May 9, 2024

Conversation

handrews
Copy link
Member

@handrews handrews commented May 1, 2024


First commit message

This reorganizes binary data-related guidance into a
"Working With Binary Data" section, as has already been
done in 3.0.4.

This includes more detailed guidance on when various
approaches to binary data make sense (e.g. you cannot
stuff raw binary into JSON no matter what you put in your
Schema Object, and while you can base64-encode entire
message bodies, it takes up a lot more space for no clear
benefit). An example that contradicts this guidance has
been removed.

The lack of and HTTP header for base64 encoding is now
explicitly called out.

Also note that only multipart media types with named parts
are supported, as they are modeled as an object.


Second commit message

Clarify how to model streaming binary data

This reorganizes binary data-related guidance into a
"Working With Binary Data" section, as has already been
done in 3.0.4.

This includes more detailed guidance on when various
approaches to binary data make sense (e.g. you cannot
stuff raw binary into JSON no matter what you put in your
Schema Object, and while you can base64-encode entire
message bodies, it takes up a lot more space for no clear
benefit).  An example that contradicts this guidance has
been removed.

The lack of and HTTP header for base64 encoding is now
explicitly called out.

Also note that only `multipart` media types with named parts
are supported, as they are modeled as an object.
@handrews handrews added clarification requests to clarify, but not change, part of the spec media and encoding Issues regarding media type support and how to encode data (outside of query/path params) labels May 1, 2024
@handrews handrews added this to the v3.2.0 milestone May 1, 2024
@handrews handrews requested a review from a team May 1, 2024 17:37
Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@ralfhandl ralfhandl merged commit 4365723 into OAI:v3.2.0-dev May 9, 2024
1 check passed
@handrews handrews deleted the binary-320 branch May 9, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification requests to clarify, but not change, part of the spec media and encoding Issues regarding media type support and how to encode data (outside of query/path params)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants