Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encapsulate page layout for extensions #3828

Merged

Conversation

Bellangelo
Copy link
Member

Partially addresses: #1823

This commit re-enables the page building of the extension which was disabled in #3212.

I have no idea why it was disabled but in production it produces a 404 link. You can check it here https://spec.openapis.org/registry/extension/index.html by clicking on the x-twitter link.

A rendered result can be seen here: https://bellangelo.github.io/OpenAPI-Specification/registry/extension/x-twitter.html

@handrews
Copy link
Member

@OAI/tsc based on #3212 there was a conscious decision to hide this registry- anyone recall why this was done and whether we should bring it back or just delete it?

@ralfhandl
Copy link
Contributor

As far as I can recall the discussion, the extension registry is practically not used and its only entry may already be obsolete. Better keep it hidden, and also hide the menu entry for it in the left side bar:
image

@Bellangelo
Copy link
Member Author

Bellangelo commented May 23, 2024

As far as I can recall the discussion, the extension registry is practically not used and its only entry may already be obsolete. Better keep it hidden, and also hide the menu entry for it in the left side bar:

Thanks for your input @ralfhandl, should we delete it then? I don't see why we should keep it if it hidden. If anyone wants to "re-enable" it later on, he can just look at the git history.

Copy link
Contributor

@lornajane lornajane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding and rescuing this

@handrews handrews merged commit d975a55 into OAI:gh-pages May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants