Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rendering of the Arazzo Specification #3842

Merged
merged 9 commits into from
May 23, 2024

Conversation

frankkilcommins and others added 7 commits May 23, 2024 10:50
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: frankkilcommins <frankkilcommins@users.noreply.github.com>
@ralfhandl
Copy link
Contributor

Looks convincing 😄

@handrews handrews requested a review from a team May 23, 2024 15:41
@handrews handrews added the script Pull requests that update Bash or JavaScript code label May 23, 2024
@handrews
Copy link
Member

@frankkilcommins why is respect-arazzo.js formatted as a single line? respec-oai.js is not, and single-line JS files are not fun for diffs (or readability at all).

@frankkilcommins
Copy link
Contributor Author

@frankkilcommins why is respect-arazzo.js formatted as a single line? respec-oai.js is not, and single-line JS files are not fun for diffs (or readability at all).

@handrews strange.....both look the same for me (very long single line at the start). The only change in the file was replacing a hardcoding "What is the OpenAPI Specification" with "What is the Arazzo Specification" as I don't have time right now to fix all the things.

@ralfhandl
Copy link
Contributor

ralfhandl commented May 23, 2024

respec-oai.js is not

It actually is a single line if you look at the raw file and not at the formatted version the Github UI renders: https://raw.githubusercontent.com/OAI/OpenAPI-Specification/gh-pages/js/respec-oai.js

@handrews
Copy link
Member

@frankkilcommins Someone explain that the GitHub view I was using of the other file formatted it, so yeah, you're fine with the one-liner as far as I'm concerned

Copy link
Contributor

@lornajane lornajane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Go Arazzo :)

@lornajane lornajane merged commit c01d8cf into OAI:gh-pages May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Housekeeping script Pull requests that update Bash or JavaScript code
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants