Typo in discriminator example #3850
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ralfhandl there are several things that need backporting from PR #2618, this is only one of them- could you close this as it will be easier for me to backport if I don't have to split pieces out. I've added #2618 to #3626 (comment) so we won't forget it. |
handrews
requested changes
May 24, 2024
|
@handrews Don't find this typo explicitly mentioned in #3626 (comment), so why not just fix it by merging this trivial PR instead of risking it falling through the cracks? Note: from my perspective 3.0.4 is the most relevant of the four spec versions we are currently working on. |
|
This is now addressed on this line of the full merge resolution backport: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the proposed change to 3.1.1 in #3846 the 3.0.4 text seems to be wrong.