Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align 3.0.4 with 3.1.1 #3954

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Conversation

ralfhandl
Copy link
Contributor

Editorial changes taken over from 3.1.1.

If we decide to reject one of these changes, we have to decide whether we want to transfer the 3.0.4 wording back to 3.1.1 via PR #3953

@ralfhandl ralfhandl changed the base branch from main to v3.0.4-dev July 12, 2024 08:38
@ralfhandl ralfhandl requested review from handrews and a team July 12, 2024 08:39
@ralfhandl ralfhandl changed the title V3.0.4/sync with 3.1.1 Align 3.0.4 with 3.1.1 Jul 12, 2024
@ralfhandl ralfhandl marked this pull request as ready for review July 12, 2024 08:41
@ralfhandl ralfhandl added the editorial Wording and stylistic issues label Jul 12, 2024
@ralfhandl ralfhandl added this to the v3.0.4 milestone Jul 12, 2024
Copy link
Contributor

@miqui miqui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ralfhandl approved, but not merge until your initial concern be addressed?

@ralfhandl ralfhandl requested a review from a team July 16, 2024 14:02
@ralfhandl
Copy link
Contributor Author

not merge until your initial concern be addressed?

Once we get a second approval this PR can be merged.

Goal is to avoid accidental differences between 3.0.4 and 3.1.1.

Copy link
Contributor

@lornajane lornajane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ralfhandl !

@lornajane lornajane merged commit 5802ec8 into OAI:v3.0.4-dev Jul 18, 2024
2 checks passed
@ralfhandl ralfhandl deleted the v3.0.4/sync-with-3.1.1 branch July 18, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Wording and stylistic issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants