Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.1.1: replace "property" with "field" or "keyword" where appropriate #4032

Merged
merged 4 commits into from
Aug 22, 2024
Merged

3.1.1: replace "property" with "field" or "keyword" where appropriate #4032

merged 4 commits into from
Aug 22, 2024

Conversation

ralfhandl
Copy link
Contributor

@ralfhandl ralfhandl added editorial Wording and stylistic issues Housekeeping labels Aug 16, 2024
@ralfhandl ralfhandl added this to the v3.1.1 milestone Aug 16, 2024
@ralfhandl ralfhandl requested a review from a team August 16, 2024 07:49
This was referenced Aug 16, 2024
Closed
Merged
@ralfhandl ralfhandl mentioned this pull request Aug 16, 2024
Merged
@ralfhandl ralfhandl added the approved pr port PRs that just port an approved PR to another version label Aug 16, 2024
@ralfhandl ralfhandl linked an issue Aug 16, 2024 that may be closed by this pull request
Usage of field vs property #2660
Closed
mikekistler
mikekistler approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@lornajane lornajane merged commit 6460549 into OAI:v3.1.1-dev Aug 22, 2024
1 check passed
@ralfhandl ralfhandl deleted the 3.1.1/property-field-keyword branch August 22, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikekistler mikekistler mikekistler approved these changes

@lornajane lornajane lornajane approved these changes

Assignees
No one assigned
Labels
approved pr port PRs that just port an approved PR to another version editorial Wording and stylistic issues Housekeeping
Projects
None yet
Milestone
v3.1.1
Development

Successfully merging this pull request may close these issues.

Usage of field vs property
3 participants
@ralfhandl @lornajane @mikekistler