-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move examples from OpenAPI-Specification repository #102
Move examples from OpenAPI-Specification repository #102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my review is in WIP @Bellangelo , @handrews - lots of files in a single PR.
Should be able to approve this soon unless @handrews , @SensibleWood , or any other user posts a concern. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good- thanks for working out the right dependencies in package.json instead of copying everything from the spec repo!
apiKey: [] | ||
app2AppOauth: | ||
- board:read | ||
- apiKey: [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs to be defaultApiKey
to match the component name under #/components/securitySchemes
.
Partially addresses: OAI/OpenAPI-Specification#3854
tictactoe
example be9af73 as it wasn't passing the tests.yaml-to-json
script.json
file for the pre-existingtictactoe
example.