Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--offset assumes base 16 #10

Closed
alexander-hanel opened this issue Jun 11, 2020 · 1 comment
Closed

--offset assumes base 16 #10

alexander-hanel opened this issue Jun 11, 2020 · 1 comment
Assignees
@idiom
Labels
bug

Comments

@alexander-hanel
Copy link

blobrunner incorrectly assumes the offset input is in base 16 or hex. For example, the two commands would jump to different offsets, even though they are equivalent.

blobrunner.exe blah.bin --offset 0xC000 
blobrunner.exe blah.bin --offset 3072
@idiom idiom self-assigned this Jun 12, 2020
@idiom idiom added the bug label Jun 12, 2020
idiom added a commit that referenced this issue Jun 12, 2020
@idiom
Fix for bug #10.
2942af6
@idiom
Copy link
Member

idiom commented Jun 12, 2020

Added check for the offset being prefixed with 0x and parse as base16.

@idiom idiom closed this as completed Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@idiom idiom

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@idiom @alexander-hanel