-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: clean up citations section + associated language #2610
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Other TODO's
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve, though I suggest that the phrase 'in a diversity of ways' be changed to 'in a variety of ways'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
citation/Citation.md
Outdated
@@ -1,46 +1,59 @@ | |||
--- | |||
layout: doc | |||
layout: citation | |||
title: OBO Citation and Attribution Policy | |||
--- | |||
|
|||
Open Biological and Biomedical Ontologies are used in a diversity of ways. The following guidelines are intended to promote proper attribution of the ontology creators and contributors, and to promote reproducibility in informatics applications. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @nataled's suggestion to change "diversity" to "variety".
Not that I know of |
Can this be squashed and merged? |
@nlharris strictly speaking, the GitHub review process wants me to re-attain Nico's approval, but I think it's implicit so I'd be happy to go ahead and squash |
It won't allow squash & merge until the requested change has been made (? I thought it already was) and 2 people approve. |
Ah, yeah, foiled by repository rules. We'll be able to once @matentzn is able to re-review. |
I think this comment was addressed.
a few possible changes -- let me know if they need to go through additional channels first:
other possible todo's: