Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] account_analytic_parent: Migration to 18.0 #698

Merged
merged 55 commits into from
Nov 26, 2024

Conversation

BernatObrador
Copy link
Contributor

Module migrated to version 18.0

cc https://github.com/APSL 161657

@miquelalzanillas @lbarry-apsl @mpascuall @peluko00 @javierobcn @ppyczko please review

@BernatObrador BernatObrador force-pushed the 18.0-mig-account_analytic_parent branch from baf63b5 to f6efa38 Compare October 9, 2024 09:59
chienandalu and others added 27 commits October 9, 2024 12:07
* Removed groups attribute in tree xml element.

* Removed discarded hierarchical tree view support, plus wizard based on that functionality
Currently translated at 100,0% (4 of 4 strings)

Translation: account-analytic-11.0/account-analytic-11.0-account_analytic_parent
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-11-0/account-analytic-11-0-account_analytic_parent/de/
Currently translated at 100,0% (4 of 4 strings)

Translation: account-analytic-11.0/account-analytic-11.0-account_analytic_parent
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-11-0/account-analytic-11-0-account_analytic_parent/ca/
Currently translated at 100.0% (5 of 5 strings)

Translation: account-analytic-12.0/account-analytic-12.0-account_analytic_parent
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-account_analytic_parent/es/
Currently translated at 100.0% (5 of 5 strings)

Translation: account-analytic-12.0/account-analytic-12.0-account_analytic_parent
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-account_analytic_parent/gl/
Currently translated at 54.5% (6 of 11 strings)

Translation: account-analytic-12.0/account-analytic-12.0-account_analytic_parent
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-account_analytic_parent/nl/
Currently translated at 100.0% (11 of 11 strings)

Translation: account-analytic-12.0/account-analytic-12.0-account_analytic_parent
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-account_analytic_parent/hr/
Currently translated at 18.2% (2 of 11 strings)

Translation: account-analytic-12.0/account-analytic-12.0-account_analytic_parent
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-account_analytic_parent/fr/
Currently translated at 90.9% (10 of 11 strings)

Translation: account-analytic-12.0/account-analytic-12.0-account_analytic_parent
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-account_analytic_parent/es/
Currently translated at 72.7% (8 of 11 strings)

Translation: account-analytic-12.0/account-analytic-12.0-account_analytic_parent
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-account_analytic_parent/ca/
Currently translated at 100.0% (11 of 11 strings)

Translation: account-analytic-12.0/account-analytic-12.0-account_analytic_parent
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-account_analytic_parent/es/
Currently translated at 100.0% (11 of 11 strings)

Translation: account-analytic-12.0/account-analytic-12.0-account_analytic_parent
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-account_analytic_parent/es/
Currently translated at 100.0% (11 of 11 strings)

Translation: account-analytic-12.0/account-analytic-12.0-account_analytic_parent
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-account_analytic_parent/pt_BR/
Currently translated at 100.0% (11 of 11 strings)

Translation: account-analytic-12.0/account-analytic-12.0-account_analytic_parent
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-account_analytic_parent/fr/
Currently translated at 100.0% (11 of 11 strings)

Translation: account-analytic-12.0/account-analytic-12.0-account_analytic_parent
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-account_analytic_parent/sl/
mymage and others added 6 commits October 9, 2024 12:07
Currently translated at 96.7% (30 of 31 strings)

Translation: account-analytic-17.0/account-analytic-17.0-account_analytic_parent
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-17-0/account-analytic-17-0-account_analytic_parent/it/
Currently translated at 100.0% (31 of 31 strings)

Translation: account-analytic-17.0/account-analytic-17.0-account_analytic_parent
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-17-0/account-analytic-17-0-account_analytic_parent/es/
Currently translated at 67.7% (21 of 31 strings)

Translation: account-analytic-17.0/account-analytic-17.0-account_analytic_parent
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-17-0/account-analytic-17-0-account_analytic_parent/ca/
Currently translated at 100.0% (31 of 31 strings)

Translation: account-analytic-17.0/account-analytic-17.0-account_analytic_parent
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-17-0/account-analytic-17-0-account_analytic_parent/zh_CN/
Currently translated at 96.7% (30 of 31 strings)

Translation: account-analytic-17.0/account-analytic-17.0-account_analytic_parent
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-17-0/account-analytic-17-0-account_analytic_parent/it/
@BernatObrador BernatObrador force-pushed the 18.0-mig-account_analytic_parent branch from f6efa38 to a61c41e Compare October 9, 2024 10:07
@BernatObrador BernatObrador force-pushed the 18.0-mig-account_analytic_parent branch from a61c41e to 91891c2 Compare October 9, 2024 10:21
@BernatObrador BernatObrador mentioned this pull request Oct 9, 2024
10 tasks
Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

Copy link

@ppyczko ppyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

Copy link
Contributor

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link

@houssine78 houssine78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@houssine78
Copy link

@pedrobaeza this PR seems ready

@pedrobaeza
Copy link
Member

@houssine78 please stop spamming me. I can't attend all your requests. This has a lot of approvals, but neither from a PSC.

@houssine78
Copy link

@pedrobaeza ok sorry. I though a PR could be merged once tagged approved and just wanted to speed up the process.

Let's wait for a PSC member to review the PRs then.

@pedrobaeza
Copy link
Member

Check https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#review

Most of the times, I launch the merge if the stuff is known or I do a quick review, but you have put me 4 messages in less than a minute about some random PRs, and as said, I can't attend blindly everything, specially if I receive complaints later (check for example OCA/purchase-workflow#2216 (comment)).

@houssine78
Copy link

Sorry for the inconvenience. I also try to make review even when there is enough ones already done. I'll follow the contribution instruction more carefully as I mostly look at the code.

If there is any way I can help. Let me know.

@pedrobaeza
Copy link
Member

OK, don't worry. On a quick glance, it seems OK, so let's go with it.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-698-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 112f80b. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit ad9e67e into OCA:18.0 Nov 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.