Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][MIG] hr_timesheet_analytic_tag: Migration to 18.0 #711

Merged
merged 10 commits into from
Nov 26, 2024
Merged

[18.0][MIG] hr_timesheet_analytic_tag: Migration to 18.0 #711

merged 10 commits into from
Nov 26, 2024

Conversation

peluko00
Copy link
Contributor

@peluko00 peluko00 commented Nov 20, 2024 •
edited
Loading

@peluko00 peluko00 mentioned this pull request Nov 20, 2024
Open
10 tasks
ppyczko
ppyczko approved these changes Nov 20, 2024
View reviewed changes
Copy link

@ppyczko ppyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@peluko00 peluko00 force-pushed the 18.0-mig-hr_timesheet_analytic_tag branch 2 times, most recently from bb145b5 to 7bbbdeb Compare November 22, 2024 07:06
mpascuall
mpascuall approved these changes Nov 22, 2024
View reviewed changes
Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

BernatObrador
BernatObrador approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@BernatObrador BernatObrador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza
pedrobaeza reviewed Nov 25, 2024
View reviewed changes
hr_timesheet_analytic_tag/tests/test_hr_timesheet_analytic_tag.py Outdated
@@ -63,27 +63,23 @@ def _create_hr_timesheet(self):
)

def test_hr_timesheet_without_tags(self):
self.task.analytic_account_id = self.analytic_account_1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why removing this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In v18 this field was removed from project.task model.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but then, analytic_account_1 is never used. If not needed, remove its creation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Thanks!

@peluko00 peluko00 force-pushed the 18.0-mig-hr_timesheet_analytic_tag branch from 7bbbdeb to 01aaa6a Compare November 26, 2024 09:38
pedrobaeza
pedrobaeza approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot migration hr_timesheet_analytic_tag
/ocabot merge nobump

@pedrobaeza
Copy link
Member

/ocabot migration hr_timesheet_analytic_tag
/ocabot merge nobump

1 similar comment
@pedrobaeza
Copy link
Member

/ocabot migration hr_timesheet_analytic_tag
/ocabot merge nobump

@pedrobaeza
Copy link
Member

@sbidoul the bot seems stuck.

@sbidoul
Copy link
Member

sbidoul commented Nov 26, 2024

/ocabot migration hr_timesheet_analytic_tag

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Nov 26, 2024
@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-711-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 26, 2024
@OCA-git-bot
Merge PR #711 into 18.0
27ba6a3 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-711-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 26, 2024
@OCA-git-bot
Merge PR #711 into 18.0
4990479 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-711-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6069ed3 into OCA:18.0 Nov 26, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ba4aeee. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppyczko ppyczko ppyczko approved these changes

@mpascuall mpascuall mpascuall approved these changes

@BernatObrador BernatObrador BernatObrador approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
18.0
Development

Successfully merging this pull request may close these issues.
9 participants
@peluko00 @OCA-git-bot @pedrobaeza @sbidoul @BernatObrador @mpascuall @ppyczko @victoralmau @mymage