[16][MIG] purchase_invoicing_no_zero_line

[florian-dacosta]

Standard migration

@pedrobaeza @victoralmau @CarlosRoca13

[pedrobaeza]

Isn't this now the standard behavior?

[florian-dacosta]

Isn't this now the standard behavior?

From the purchase order, with the button "CREATE BILL", it is, there are no 0 quantity lines.
But when you create a supplier bill and add the PO number in the "Auto-Complete" field, it still add 0 quantity lines in v16.
Here : https://github.com/odoo/odoo/blob/17.0/addons/purchase/models/account_invoice.py#L65 There is no mechanism to avoid these 0 lines.

[SirAionTech]

Thanks for the PR!
I have tried it locally (runboat is down), reviewed the commits and the code.

Could you please squash the commit history according to https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate?
Without bots' commits the history is basically a handful of commits.

[florian-dacosta]

Thanks for the PR! I have tried it locally (runboat is down), reviewed the commits and the code.

Could you please squash the commit history according to https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate? Without bots' commits the history is basically a handful of commits.

Thanks for the review. I believe I have attended all comments, please feel free to update your review

[SirAionTech]

Translation commits have been squashed with other commits, so now the translators do not appear anymore in the commit history.
The translation commits should only have been squashed with one another according to https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate, could you please check?

[florian-dacosta]

could you please check?

Oops, nice catch, I was not seeing the authors in my rebase, I've changed this and made it once again, it should be good now. There was only 1 no-bot translation author (and 2 commit squashed together)

[clementmbr]

Only code review but LGTM!

[bguillot]

/ocabot merge nobump

[bguillot]

thanks

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1602-by-bguillot-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at cffbc52. Thanks a lot for contributing to OCA. ❤️