Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] : Migration partner_invoicing_mode to 18.0 #1833

Open
wants to merge 23 commits into
base: 18.0
Choose a base branch
from

Conversation

chaule97
Copy link

@chaule97 chaule97 commented Nov 6, 2024

  • If a field is marked as readonly=True on the model, it won't be possible to import it through the Odoo import tool, so we avoid it as possible and define the readonly attribute on the views instead.

TDu and others added 21 commits November 4, 2024 15:55
[UPD] Update partner_invoicing_mode.pot

[UPD] README.rst

partner_invoicing_mode 16.0.1.0.1
Translated using Weblate (Spanish)

Currently translated at 100.0% (8 of 8 strings)

Translation: account-invoicing-16.0/account-invoicing-16.0-partner_invoicing_mode
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-partner_invoicing_mode/es/

[UPD] README.rst
Translated using Weblate (Italian)

Currently translated at 100.0% (8 of 8 strings)

Translation: account-invoicing-16.0/account-invoicing-16.0-partner_invoicing_mode
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-partner_invoicing_mode/it/
Allow to have a better extension mechanism when having multiple invoicing
modes.
The field one_invoice_per_order wasn't used correctly.

So, now, create invoices using the partner option by calling
the grouping option on sale orders
To improve flexibility, the invoicing grouping option could be different
on the sale order level than on the partner level.
As the read_group() can aggregate sale order ids per partner,
use the ids list instead.
…al field

As a company can have several different invoicing address, invoicing can occur at different
dates.
…tion

As validation jobs could last long time if there are plenty, ensure that
the wanted date is correctly set.
In order to be able to benefits from standard grouping function, override it
and add missing keys.

[UPD] Update partner_invoicing_mode.pot

[BOT] post-merge updates

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-invoicing-16.0/account-invoicing-16.0-partner_invoicing_mode
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-partner_invoicing_mode/

Translated using Weblate (Italian)

Currently translated at 94.4% (17 of 18 strings)

Translation: account-invoicing-16.0/account-invoicing-16.0-partner_invoicing_mode
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-partner_invoicing_mode/it/

Translated using Weblate (Italian)

Currently translated at 100.0% (18 of 18 strings)

Translation: account-invoicing-16.0/account-invoicing-16.0-partner_invoicing_mode
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-partner_invoicing_mode/it/

Translated using Weblate (Spanish)

Currently translated at 100.0% (18 of 18 strings)

Translation: account-invoicing-16.0/account-invoicing-16.0-partner_invoicing_mode
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-partner_invoicing_mode/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-invoicing-17.0/account-invoicing-17.0-partner_invoicing_mode
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-17-0/account-invoicing-17-0-partner_invoicing_mode/
Currently translated at 100.0% (18 of 18 strings)

Translation: account-invoicing-17.0/account-invoicing-17.0-partner_invoicing_mode
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-17-0/account-invoicing-17-0-partner_invoicing_mode/it/
Copy link
Member

@TDu TDu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I think there is an issue with the sale dependency that is not installed...
image
So I would think the change on sale.order view is not applied ?

@TDu
Copy link
Member

TDu commented Nov 6, 2024

Actually, I think there is an issue with the sale dependency that is not installed... image So I would think the change on sale.order view is not applied ?
Finally installing the sale_management app and it works, so looks good 🤔
Yeah forget about my comment 🫨 sale was installed.

@@ -6,7 +6,8 @@
from freezegun import freeze_time

from odoo import fields
from odoo.tests.common import Form, TransactionCase
from odoo.tests import Form
from odoo.tests.common import TransactionCase
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why CommonPartnerInvoicingMove isn't depending on TransactionCase?
It implements setUpClass and calls super() which no parent class implements.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated CommonPartnerInvoicingMove depending on TransactionCase

@chaule97 chaule97 force-pushed the 18.0-mig-partner_invoicing_mode branch from 03a1367 to 2a89ba9 Compare November 8, 2024 07:50
@chaule97
Copy link
Author

chaule97 commented Nov 8, 2024

Hello everyone, I have changed a little about readonly attribute in model and field

@TDu
Copy link
Member

TDu commented Nov 22, 2024

base_partition has been mergedhttps://github.com/OCA/server-tools/pull/3077 that DON'T MERGE commit can be removed. Thanks

@chaule97 chaule97 force-pushed the 18.0-mig-partner_invoicing_mode branch from 2a89ba9 to a108a3f Compare November 22, 2024 17:53
@chaule97
Copy link
Author

base_partition has been mergedhttps://github.com/OCA/server-tools/pull/3077 that DON'T MERGE commit can be removed. Thanks

I have removed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants