[17.0][IMP] account_reconcile_oca: Add validation for applicability of analytic plans #764
Conversation
|
Hi @etobella, |
|
Please add more context, as the code is not easy to be interpreted |
|
Hi, @pedrobaeza! I was writing it, sorry! Now you can review it with the context of the improvement! |
|
Next time please do that in one shot, and that context should be also in the expanded message commit, not only in the PR. Please add it. |
|
Apart from that, as you are doing another bugfix, that should be in a separate commit with its explanation. |
|
@pedrobaeza Thanks for your time! Will do the changes now! |
…ytic plans
adds validation for the applicability of analytic plans, ensuring that mandatory plans or accounts requiring analytic imputations are properly validated.
The validate_analytic context is used in the analytic mixin to validate the applicability of analytic plans when generating analytic lines.
BernatObrador
force-pushed
the
17.0-imp-account_reconcile_oca
branch
from
cfc3e51 to
dcd69cc
Compare
|
You can add here the other bugfix, but in a separate commit. |
|
@pedrobaeza I've done that in another PR! Here i'ts: #765 |
|
Well, 2 different commits don't mean 2 different PRs, but don't worry, you can leave it this way now. Just take it into account for the next time if you want to save one PR, but it's not bad at all, as each one can be handled on their own times. |
|
@pedrobaeza, I’ll take it from here! Really appreciate your time and help! |
|
/ocabot merge patch Please backport it to 16 |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at c508867. Thanks a lot for contributing to OCA. ❤️ |
This PR adds validation for the applicability of analytic plans, ensuring that mandatory plans or accounts requiring analytic imputations are properly validated.
The
validate_analyticcontext is used in the analytic mixin to validate the applicability of analytic plans when generating analytic lines.cc https://github.com/APSL 164854
@miquelalzanillas @lbarry-apsl @mpascuall @peluko00 @javierobcn @ppyczko please review