Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] account_payment_purchase_stock #1063

Merged
merged 18 commits into from
Jun 2, 2023

Conversation

SodexisTeam
Copy link
Member

This module depends on account_payment_purchase.
There is an existing PR for the migration of account_payment_purchase in the repository.
#1004

@SodexisTeam SodexisTeam force-pushed the 16.0-mig-account_payment_purchase_stock branch from efcecc1 to cd11b86 Compare March 14, 2023 10:15
@stefan-tecnativa
Copy link
Contributor

The account_payment_purchase module has already been merged, so you can remove your requirements commit. But check why tests are failling

astirpe and others added 18 commits June 2, 2023 13:18
Currently translated at 100.0% (4 of 4 strings)

Translation: bank-payment-14.0/bank-payment-14.0-account_payment_purchase_stock
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-14-0/bank-payment-14-0-account_payment_purchase_stock/es_AR/
Currently translated at 75.0% (3 of 4 strings)

Translation: bank-payment-14.0/bank-payment-14.0-account_payment_purchase_stock
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-14-0/bank-payment-14-0-account_payment_purchase_stock/fr_FR/
…or bank PO

- Only issue a warning message if the PO had a non-blank payment mode or bank.
Currently translated at 100.0% (4 of 4 strings)

Translation: bank-payment-14.0/bank-payment-14.0-account_payment_purchase_stock
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-14-0/bank-payment-14-0-account_payment_purchase_stock/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: bank-payment-15.0/bank-payment-15.0-account_payment_purchase_stock
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-15-0/bank-payment-15-0-account_payment_purchase_stock/
@amkarthik amkarthik force-pushed the 16.0-mig-account_payment_purchase_stock branch from fb232d5 to 5a899bb Compare June 2, 2023 07:50
@amkarthik
Copy link
Member

@stefan-tecnativa
Removed the dependency. All tests succeeded now.

Copy link
Contributor

@stefan-tecnativa stefan-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@atchuthan atchuthan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge nobump
/ocabot migration account_payment_purchase_stock

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1063-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jun 2, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Jun 2, 2023
14 tasks
@OCA-git-bot OCA-git-bot merged commit 536ab95 into OCA:16.0 Jun 2, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d97ffd3. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.