[13.0][IMP] account_payment_order - move date should be bank line date when offsetting_account is bank_account

[baimont]

Between Odoo v10.0 and Odoo v13.0, date fields on account.move and account.move.line became readonly. In both versions, date field on account.move.line is a related of the account.move one. This means that when creating our move in v10.0, date from account.move would take value of account.move.line. This is not true anymore with the readonly attributes. This is a way to return to that behavior.

[pedrobaeza]

Please specify steps to reproduce the problem.

[sanrav]

Steps to test :

• Configure a bank journal with a bank account

• Configure a payment mode "SEPA Credit Transfer to suppliers" with Offsetting account = Bank account

• Create a vendor bill and post it

• Create a payment order with Due date as Payment Execution Date Type

• Confirm payments, generate xml file and confirm the upload => journal entry is created with accounting date = payment date

[sanrav]

Functional testing OK

[pedrobaeza]

I think the problem is that you are not putting on "Move Option", "One move per payment date", and that's the problem. This PR is not correct, assigning randomly the date of the first line.

[sanrav]

I tested also with "One move per payment date" and the issue is the same. The accounting entry takes the today's date instead of payment date. Tests done on runbot OCA V13.

If you choose "One move per payment line", there is one accounting entry per payment line. So, one payment date.
If you choose "One move per payment date", we can have more than one payment line grouped into one accounting entry. But as they are grouped by payment date, we will have the same payment date on each line. So, I don't see the issue to choose randomly the date of the first line.

[pedrobaeza]

@carlosdauden didn't you add such option of propagating the date?

[carlosdauden]

I have commented this problem sometime, but since our clients did not open any issue (most of our clients use offsetting_account == "transfer_account" or they have a fix date of payment) I have not found the time to do it.

[pedrobaeza]

Thanks for the confirmation and the contribution:

/ocabot merge patch

Can you fw-port it to v14?

[OCA-git-bot]

On my way to merge this fine PR!
Prepared branch 13.0-ocabot-merge-pr-805-by-pedrobaeza-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 0ed4b8e. Thanks a lot for contributing to OCA. ❤️