[16.0][MIG] account_banking_sepa_credit_transfer: Migration to 16.0 #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzungtran89
force-pushed
the
16.0-account_banking_sepa_credit_transfer
branch
from
c01e343 to
6edf837
Compare
|
cc @dzungtran89 You can remove this dependency #972 |
dzungtran89
force-pushed
the
16.0-account_banking_sepa_credit_transfer
branch
2 times, most recently
from
4146db9 to
0c8b082
Compare
|
Hi @StephaneMangin , the PR has been updated |
|
You are missing dependencies For the PR dependency, please take in account this comment OCA/edi#724 (comment) |
|
There's a wiki entry for it: https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29 |
dzungtran89
force-pushed
the
16.0-account_banking_sepa_credit_transfer
branch
from
80e51c1 to
878e85b
Compare
|
(checking the failed test case) |
dzungtran89
changed the title
dzungtran89
force-pushed
the
16.0-account_banking_sepa_credit_transfer
branch
2 times, most recently
from
b3d207a to
0e31e51
Compare
|
dzungtran89
force-pushed
the
16.0-account_banking_sepa_credit_transfer
branch
from
0e31e51 to
0038d87
Compare
|
/ocabot migration account_banking_sepa_credit_transfer Please rebase and remove the temporary commit. |
|
And please include #1084 |
* Small API changes * Updated two additional imports to new API * A payment mode type needs a suitable bank type
…tion of the SEPA XML file is now really working Update views to 7.0-style Better error handling when Bank account in missing on the invoice.
…tures available without pulling bank statement features - introduce account_banking_payment_export module with all features from account_banking_payment that do not involve changing the payment order workflow or depend on bank statement changes - account_banking_payment_export does not depend on account_banking - account_banking_payment is consequently stripped of above features - account_banking_sepa_credit_transfer depend on account_banking_payment_export and is compatible with the default payment order workflow - clarified comment about workflow in account_banking_sepa_credit_transfer - avoid generating invalid sepa credit transfer files when bank accounts have no BIC
…e instead of tomorrow
…r things:
* Add support for pain.001.001.05 Fix dependencies (I need the field "payment_order_type" which is in account_banking_payment) Only use ASCII characters in the XML file (that's how banks use XML !) Use the payment order reference as the Message Identification of the XML file. Use the payment line sequence as the "End to End Identification" Remove the Instruction Identification ('InstrId') because it is not a required field (only the End to End identification is required) Rename variables in the function create_sepa() to include the number of each field as used in the EPC guidelines Reduce the number of flake8 warnings Make code more modular : - self.pool.get('banking.export.sepa').create() has a _prepare fonction - most of the content of the XML file can be inherited via _prepare_field()
* Update strings. Update FR translation.
* fields.date.context_today doesn't work with datetime => we now use the native field create_date Coding style improvements.
* Add logo
* Better prototype for the _prepare_field function. Update help message, POT file and FR translation. * Revert the dependancy to account_banking_payment_export (the field payment_order_type on payment.mode.type has a default value of "payment" anyway). * Akretion-Noviat code sprint dated 2013-11-21: - add module account_banking_pain_base - add support for initiating party identification, priority and structured remittance info in XML file - the requested execution date now uses the fields date_prefered and date_scheduled (the field of the wizard has been removed) - the 'convert to ascii' feature is now an option of the payment mode (enabled by default) - set 'communication' field of payment.line to 140 chars and hide field 'communicatio n2' * FIX label : Customer (which is wrong, it is most of the time a Supplier !)-> Creditor More PEP8 stuff.
Currently translated at 100.0% (17 of 17 strings) Translation: bank-payment-14.0/bank-payment-14.0-account_banking_sepa_credit_transfer Translate-URL: https://translation.odoo-community.org/projects/bank-payment-14-0/bank-payment-14-0-account_banking_sepa_credit_transfer/sv/
Currently translated at 100.0% (14 of 14 strings) Translation: bank-payment-15.0/bank-payment-15.0-account_banking_sepa_credit_transfer Translate-URL: https://translation.odoo-community.org/projects/bank-payment-15-0/bank-payment-15-0-account_banking_sepa_credit_transfer/ca/
…, account_banking_direct_debit: Remove Environment.manage() Environment.manage() is deprecated in v 15.0
…to pain.001.001.03
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: bank-payment-15.0/bank-payment-15.0-account_banking_sepa_credit_transfer Translate-URL: https://translation.odoo-community.org/projects/bank-payment-15-0/bank-payment-15-0-account_banking_sepa_credit_transfer/
From this version, Odoo already includes code on the account.payment.method creation for adding such method to each journal: https://github.com/odoo/odoo/blob/a93ed75cb80f16f/addons/account/models/account_payment_method.py#L24-L38 so we don't need to explicitly create them for the new payment methods we are adding in these modules. TT41146
…yment refactoring Notables changes: - InstrId and EndToEndId tags are now filled with the journal entry ID, as there's no bank payment line identifier.
…or in the tests In case the currency is not active, the test fails because an invoice cannot be validated with an inactive currency TT43341
dzungtran89
force-pushed
the
16.0-account_banking_sepa_credit_transfer
branch
from
0038d87 to
75a4f1c
Compare
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 249b120. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#964
Depends: