Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][ADD] calendar_monthly_multi: Calendar monthly extension #103

Merged
merged 1 commit into from
Oct 4, 2024
Merged

[16.0][ADD] calendar_monthly_multi: Calendar monthly extension #103

merged 1 commit into from
Oct 4, 2024

Conversation

tarteo
Copy link
Member

@tarteo tarteo commented Sep 20, 2023

This module extends the functionality of monthly recurring events in the calendar:

  1. Multiple dates: For example every 5th and 15th of the month
  2. All days, Weekday (monday to friday), weekend days (saturday and sunday) or
    custom    : For example The first weekday of the month

multiple-dates

weekday-weekendday

@tarteo tarteo force-pushed the 16-add-calendar-monthly-multi branch 5 times, most recently from e578690 to c65e783 Compare September 27, 2023 14:33
@tarteo tarteo force-pushed the 16-add-calendar-monthly-multi branch from c65e783 to 392f414 Compare September 28, 2023 12:40
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 12, 2024
@OpenCode
Copy link

@tarteo Can you remove "fixup" strings from the commit body, please?

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 19, 2024
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 22, 2024
@tarteo tarteo force-pushed the 16-add-calendar-monthly-multi branch from 392f414 to a0381d4 Compare October 4, 2024 08:58
@tarteo
Copy link
Member Author

tarteo commented Oct 4, 2024

@OpenCode Hey man, sorry for the super late response but I removed it 😉

@OpenCode
Copy link

OpenCode commented Oct 4, 2024

@OpenCode Hey man, sorry for the super late response but I removed it 😉

Don't worry. Take your time 🤣

There are red tests.

@tarteo
Copy link
Member Author

tarteo commented Oct 4, 2024 •
edited
Loading

@OpenCode Hmmm, something has changed in Odoo why my tests are not green anymore. I pin pointed it to this commit: odoo/odoo@43a774d#diff-6c4c124bfb9e4397bed7221c7534c8f877904775e9db4cf81f72b5430b36ad06R631
Also the way the name of a recurrence is created it changed but I'll leave my code as is for that part

I'll let you know when I fixed it

@tarteo tarteo force-pushed the 16-add-calendar-monthly-multi branch from 3a93c58 to 54fa654 Compare October 4, 2024 13:07
@tarteo
Copy link
Member Author

tarteo commented Oct 4, 2024

@OpenCode fixed the tests 🎉

@OpenCode
Copy link

OpenCode commented Oct 4, 2024

@OpenCode fixed the tests 🎉

Can you squash the commits in the first one?

@tarteo
[ADD] calendar_monthly_multi: Calendar monthly extension
fbe8e6f 
[FIX] calendar_monthly_multi: make work with latest version of Odoo 16.0
@tarteo tarteo force-pushed the 16-add-calendar-monthly-multi branch from 54fa654 to fbe8e6f Compare October 4, 2024 13:53
@tarteo
Copy link
Member Author

tarteo commented Oct 4, 2024

@OpenCode ✔️

pedrobaeza
pedrobaeza approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick code review, but being a new module and coming from a trusted contributor, I think it's enough.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-103-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b4e63e7 into OCA:16.0 Oct 4, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6514db1. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@OpenCode OpenCode OpenCode approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tarteo @OpenCode @OCA-git-bot @pedrobaeza