[18.0][ADD] calendar_public_holiday

[xaviedoanhduy]

context:

• from this comment [16.0] hr_holidays_public: Deprecate use of employee_id in favour of partner_id hr-holidays#110 (comment), extract some features from hr_holidays_public module into new module so that it can be used in other contexts and no longer depends on HR.

note:

• rename the hr.holidays.public model and related models to calendar.public.holiday to match the Calendar repo.
• fix words like Holidays Public to Public holidays (because it is misspelled)
• moving tests and modifications from the old module will only concern the scope of functions in this module.

[victoralmau]

Code and functional review.

IMO the copyright of the corresponding files must be maintained to respect the attribution of all because this module is a “split” of the already existing hr_holidays_public module.

[xaviedoanhduy]

Code and functional review.

IMO the copyright of the corresponding files must be maintained to respect the attribution of all because this module is a “split” of the already existing hr_holidays_public module.

thanks for your suggestion, I have updated the copyright.

[victoralmau]

Ping @chienandalu

[pedrobaeza]

Isn't the migration scripts missing here?

[chienandalu]

Isn't the migration scripts missing here?

I'd say that the hr_holidays_public stuff relative to time-off is goint to be still needed so the migration work could be done there, isn't it?

[pedrobaeza]

I think it should be done here, as the public holidays should be transferred here.

[xaviedoanhduy]

DRAFT: ADDING MIGRATION SCRIPT DATA