Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][MIG] Migration of l10n_eu_product_adr and l10n_eu_adr_report #80

Merged
merged 2 commits into from
Dec 16, 2020
Merged

[13.0][MIG] Migration of l10n_eu_product_adr and l10n_eu_adr_report #80

merged 2 commits into from
Dec 16, 2020

Conversation

guewen
Copy link
Member

@guewen guewen commented Jan 13, 2020

Migration of #77

jgrandguillaume
jgrandguillaume approved these changes Mar 23, 2020
View reviewed changes
Copy link
Member

@jgrandguillaume jgrandguillaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgrandguillaume jgrandguillaume mentioned this pull request May 28, 2020
Closed
62 tasks
jgrandguillaume
jgrandguillaume approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@jgrandguillaume jgrandguillaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tested

@jgrandguillaume
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-80-by-jgrandguillaume-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 29, 2020
@OCA-git-bot
Merge PR #80 into 13.0
66876c0 
Signed-off-by jgrandguillaume
@OCA-git-bot
Copy link
Contributor

@jgrandguillaume your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-80-by-jgrandguillaume-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@i-vyshnevska i-vyshnevska force-pushed the 13.0-l10n_eu_product_adr branch 3 times, most recently from ecce55a to 1036df3 Compare June 24, 2020 11:00
@i-vyshnevska i-vyshnevska force-pushed the 13.0-l10n_eu_product_adr branch 2 times, most recently from fd8fe1b to de2a60a Compare July 14, 2020 11:38
@grindtildeath grindtildeath mentioned this pull request Jul 16, 2020
Closed
1 task
@i-vyshnevska i-vyshnevska force-pushed the 13.0-l10n_eu_product_adr branch from 7eda3b1 to e3ad029 Compare July 22, 2020 07:02
@simahawk
Copy link

simahawk commented Jul 24, 2020 •
edited
Loading

@i-vyshnevska can you squash when done?

simahawk
simahawk requested changes Jul 24, 2020
View reviewed changes
l10n_eu_adr_report/__manifest__.py Show resolved Hide resolved
l10n_eu_adr_report/readme/ROADMAP.rst Show resolved Hide resolved
l10n_eu_adr_report/report/dangerous_delivery_report.py Outdated Show resolved Hide resolved
l10n_eu_product_adr/models/product_template.py Outdated Show resolved Hide resolved
l10n_eu_product_adr/views/product_template_view.xml Outdated Show resolved Hide resolved
@i-vyshnevska i-vyshnevska force-pushed the 13.0-l10n_eu_product_adr branch from e3ad029 to 3c1c3fe Compare July 24, 2020 10:49
@i-vyshnevska
Copy link
Member

@simahawk updated

@i-vyshnevska i-vyshnevska force-pushed the 13.0-l10n_eu_product_adr branch from 05e3c13 to 77fdba4 Compare July 27, 2020 15:24
@i-vyshnevska i-vyshnevska force-pushed the 13.0-l10n_eu_product_adr branch 2 times, most recently from cd96e28 to 7f2be2b Compare August 7, 2020 09:40
@jgrandguillaume
Copy link
Member

@i-vyshnevska Can you check the last required changes so we can merge this one ?

@bosd
Copy link
Contributor

bosd commented Dec 15, 2020

What needs to be done to get this one merged?

@simahawk
Copy link

@i-vyshnevska ping :)

@i-vyshnevska i-vyshnevska force-pushed the 13.0-l10n_eu_product_adr branch from 67a1827 to 2a52a39 Compare December 16, 2020 09:10
@i-vyshnevska i-vyshnevska force-pushed the 13.0-l10n_eu_product_adr branch from 2a52a39 to 0391c8f Compare December 16, 2020 09:17
@simahawk
Copy link

@i-vyshnevska if your work is over, please squash :)

@i-vyshnevska i-vyshnevska force-pushed the 13.0-l10n_eu_product_adr branch from 0391c8f to c091dad Compare December 16, 2020 09:58
@simahawk
Copy link

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 13.0-ocabot-merge-pr-80-by-simahawk-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7a4e41f into OCA:13.0 Dec 16, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1bb5728. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i-vyshnevska i-vyshnevska i-vyshnevska left review comments

@mmequignon mmequignon mmequignon left review comments

@simahawk simahawk simahawk requested changes

@jgrandguillaume jgrandguillaume jgrandguillaume approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@guewen @jgrandguillaume @OCA-git-bot @simahawk @i-vyshnevska @bosd @mmequignon