Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] delivery_postlogistics: Migration to 17.0 #850

Draft
wants to merge 37 commits into
base: 17.0
Choose a base branch
from

Conversation

BT-dmoreno
Copy link

No description provided.

@rousseldenis
Copy link
Contributor

/ocabot migration delivery_postlogistics

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jul 8, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Jul 8, 2024
28 tasks
@BT-dmoreno BT-dmoreno force-pushed the 17.0-mig-delivery_postlogistics branch from 49a912f to 7d854fa Compare July 8, 2024 08:40
@BT-dmoreno BT-dmoreno force-pushed the 17.0-mig-delivery_postlogistics branch 4 times, most recently from 7c56a32 to e4b4f62 Compare July 18, 2024 07:29
Copy link

@BT-cjimeno BT-cjimeno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@BT-mdanek BT-mdanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@BT-dmoreno
Copy link
Author

Hi @gurneyalex, do you know who could take care of this, to have it merged at this point?

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 29, 2024
@BT-dmoreno
Copy link
Author

@OCA/logistics-maintainers any chance on this getting merged? could you please let me know what is missing?
Thanks a lot.

Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't merge v17 back in your branch but rebase instead.
You need to split API changes and migration changes in separate topics

@BT-dmoreno BT-dmoreno marked this pull request as draft December 30, 2024 14:54
@BT-dmoreno BT-dmoreno force-pushed the 17.0-mig-delivery_postlogistics branch from dd17057 to e4b4f62 Compare December 30, 2024 15:00
mmequignon and others added 29 commits December 30, 2024 16:15
history_ids has been removed as below link. So the code is obsoleted.

odoo/odoo@b3180c8#diff-9a22420c4a72cc9b6d558b3d832846c2e44a4f3731c6df9579d66c6279c4804eL54-L57

_get_origin_pickings is to determine number of pickings of a sale order.
So it should get pickings from sale_id of found picking.
The cassette `tests/fixtures/cassettes/test_store_label.yaml` should be
updated as the label was failed to decode in both 13.0 and 14.0.

* https://github.com/odoo/odoo/blob/13.0/odoo/addons/base/models/ir_attachment.py#L212
* https://github.com/odoo/odoo/blob/14.0/odoo/addons/base/models/ir_attachment.py#L554

We can remove the method _selection_file_type with below reasons.

* It is used in base_delivery_carrier_label but was removed on Sep 5, 2019
  https://github.com/OCA/delivery-carrier/blame/12.0/base_delivery_carrier_label/models/shipping_label.py#L15
* PR migration to 13.0 of base_delivery_carrier_label was merged on Oct 22, 2020
  https://github.com/OCA/delivery-carrier/pull/251/files
* Dependency on base_delivery_carrier_label was removed in migration to 14.0 on Apr 14 2021
  OCA@4ba2b56#diff-f16078e35000c05a9b63f5e7e04b6f5fd50eadae8b14a45aa9c1eb078031060cL12 OCA@4ba2b56#diff-08c11b571d9c0b0c509c3922c77f407ef4c429473fda9bc2d4d542520e7a4e3fR12
Currently translated at 100.0% (147 of 147 strings)

Translation: delivery-carrier-16.0/delivery-carrier-16.0-delivery_postlogistics
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-16-0/delivery-carrier-16-0-delivery_postlogistics/es/
Sender address must be trimmed to 35 characters for return labels as well
(it is already done for delivery label a few lines above)
@BT-dmoreno BT-dmoreno force-pushed the 17.0-mig-delivery_postlogistics branch from ee568df to 7e5d3e6 Compare December 30, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration needs review stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.