[16.0][ADD] delivery_package_sscc #902
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaspaulb
force-pushed
the
16.0-add-sequence_sscc
branch
3 times, most recently
from
693c003 to
3bc1a8f
Compare
This module allows to generate SSCC codes for packages automatically.
thomaspaulb
force-pushed
the
16.0-add-sequence_sscc
branch
from
3bc1a8f to
e18b372
Compare
sebalix
reviewed
Dec 20, 2024
There was a problem hiding this comment.
Nice addition, but should not this module lands in https://github.com/OCA/stock-logistics-tracking or https://github.com/OCA/stock-logistics-barcode ?
It's not linked directly to delivery carriers IMO, so the module should be renamed stock_quant_package_sscc for instance.
Co-authored-by: Sébastien Alix <sebalix@users.noreply.github.com>
|
@sebalix You're probably right, I was confused as to where to place it myself. It seems to be linked to delivery in my mind because it's a tracking code for the packages that get sent out. Which of the two would you suggest to put it? |
|
I would go for the tracking one, but let ask others opinions |
jbaudoux
requested changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module allows to generate SSCC codes for packages automatically.
Eg
stock.quant.package.namechanges from PACK000001..000002 etc to an actual valid SSCC code, taken from a range that can be configured.This also makes Odoo's stock.quant.package.valid_sscc flag True for any newly created package.