Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] delivery_package_fee: Migration to 18.0 #921

Merged
merged 30 commits into from
Dec 31, 2024

Conversation

chaule97
Copy link

guewen and others added 29 commits December 23, 2024 11:55
A list of Package Fees can be added on shipping methods.
When a outgoing transfer is done, for each package fee configured on the
shipping method, a new sale order line is created with:

* The product selected on the Package Fee
* The product name with the number of the transfer in the line's description
  (e.g. "Service Fee (WH/OUT/00036)")
* The quantity equal to the number of packages in the transfer
* The unit price equal to the price set on the product's pricelist (so it can be
  different per customer and even have different pricing depending on the number
  of packages)
* The taxes configured on the product, fiscal position applies if any.

Package Fee lines are added only if their quantity and price is above zero.
Flag package fee order lines with a new boolean 'is_delivery_package_fee'.
Standard method '_is_delivery' will also consider this field to exclude
the lines from the computation of the 'expected_date' in 'sale' module.
'order_line' can be empty when SO is copied
from direct call to copy with False as default.
Currently translated at 100.0% (19 of 19 strings)

Translation: delivery-carrier-16.0/delivery-carrier-16.0-delivery_package_fee
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-16-0/delivery-carrier-16-0-delivery_package_fee/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: delivery-carrier-16.0/delivery-carrier-16.0-delivery_package_fee
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-16-0/delivery-carrier-16-0-delivery_package_fee/
Currently translated at 100.0% (19 of 19 strings)

Translation: delivery-carrier-16.0/delivery-carrier-16.0-delivery_package_fee
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-16-0/delivery-carrier-16-0-delivery_package_fee/it/
Currently translated at 89.4% (17 of 19 strings)

Translation: delivery-carrier-16.0/delivery-carrier-16.0-delivery_package_fee
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-16-0/delivery-carrier-16-0-delivery_package_fee/fr/
Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG
Some rewording

Comment on lines 3 to 4
A list of Package Fees can be added on shipping methods. When a outgoing
transfer is done, for each package fee configured on the shipping
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A list of Package Fees can be added on shipping methods. When a outgoing
transfer is done, for each package fee configured on the shipping
A list of Package Fees can be configured on delivery methods. When a outgoing
transfer is done, for each package fee configured on the delivery

# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
{
"name": "Delivery Package Fees",
"summary": "Add fees on delivered packages on shipping methods",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"summary": "Add fees on delivered packages on shipping methods",
"summary": "Add fees on sales order for delivered packages",


A list of Package Fees can be added on shipping methods. When a outgoing
transfer is done, for each package fee configured on the shipping
method, a new sale order line is created with:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
method, a new sale order line is created with:
method, a new sales order line is created with:

@chaule97 chaule97 force-pushed the 18.0-mig-delivery_package_fee branch from 1b2e553 to ecfeffd Compare December 31, 2024 02:03
@chaule97 chaule97 requested a review from jbaudoux December 31, 2024 02:05
@jbaudoux
Copy link
Contributor

/ocabot migration delivery_package_fee

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Dec 31, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 31, 2024
11 tasks
@jbaudoux
Copy link
Contributor

/ocabot merge nobump delivery_package_fee

@OCA-git-bot
Copy link
Contributor

Hi @jbaudoux. Your command failed:

Invalid options for command merge: nobump delivery_package_fee.

Ocabot commands

  • ocabot merge major|minor|patch|nobump
  • ocabot rebase
  • ocabot migration {MODULE_NAME}

More information

@jbaudoux
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-921-by-jbaudoux-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 967716d into OCA:18.0 Dec 31, 2024
4 of 6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f55679d. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.