-
-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0] [ADD] delivery_state_manual #924
[16.0] [ADD] delivery_state_manual #924
Conversation
7be38f5
to
7af67a5
Compare
7af67a5
to
cade345
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tisho99 Hi Alberto!
Hi Alberto!
There’s a behavior regarding the setting of the delivery date (date_delivered) that, as I see it, is currently set at the moment in the "shipping_recorded_in_carrier" and "customer_delivered" states. I think it would be more appropriate for "shipping_recorded_in_carrier" to remain hidden and for the date to be set and visible in the "warehouse_delivered" state, which is essentially another type of delivery.
Let me explain: the "shipping_recorded_in_carrier" state is meant to represent the first step, where the goods are handed over to the person responsible for transporting them to the client, whether it’s an agency or an in-house driver. The delivery date should be set when the goods have reached their destination, and I believe the two states I mentioned align better with that timing.
If we decide to make this change, we should also update the README accordingly. Just something to keep in mind. What do you think?
cade345
to
db3a2eb
Compare
Okay, i see it well I replaced the "shipping_recorded_in_carrier" state for the "warehouse_delivered" state in the code |
af05058
to
b6b922a
Compare
b6b922a
to
4206858
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tested in local enviroment.
4206858
to
ac8404f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technical review. LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
This PR has the |
@etobella Do you mind merging this one? All the comments have been considered. THX! |
/ocabot merge nobump |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at 1ca0ccb. Thanks a lot for contributing to OCA. ❤️ |
This module extends the functionality of delivery_state to allow you to manually edit the delivery state of pickings with specific delivery carriers
T-7072