Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][ADD] website_sale_wishlist_menuitem #779

Open
wants to merge 1 commit into
base: 15.0
Choose a base branch
from
Open

[15.0][ADD] website_sale_wishlist_menuitem #779

wants to merge 1 commit into from

Conversation

AungKoKoLin1997
Copy link

This module adds a menuitem for internal users to be able to check/manage the wishlist content in the backend.

@qrtl

yostashiro
yostashiro approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test in a local environment. 👍

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 15.0-add-website_sale_wishlist_menuitem branch from d98e19e to 7b7bd42 Compare April 28, 2023 09:21
Highcooley
Highcooley approved these changes May 9, 2023
View reviewed changes
Copy link

@Highcooley Highcooley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally OK.

I am wondering if we should group wishlist items by visitor instead of user, so we can distinguish individual lists also for non registered users for marketing analysis and customer profiling. Also the view should probably have a default filter to group either by product or by visitor/user.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@AungKoKoLin1997
Copy link
Author

@OCA/e-commerce-maintainers Is it possible to take a look at this PR?

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 15.0-add-website_sale_wishlist_menuitem branch from 7b7bd42 to 367c33e Compare August 30, 2023 08:20
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 15.0-add-website_sale_wishlist_menuitem branch 2 times, most recently from daf9e89 to f09c1c7 Compare December 1, 2023 07:38
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 15.0-add-website_sale_wishlist_menuitem branch from f09c1c7 to e863fd7 Compare February 1, 2024 03:09
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 15.0-add-website_sale_wishlist_menuitem branch from e863fd7 to 8b3383b Compare April 18, 2024 02:31
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 18, 2024
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 15.0-add-website_sale_wishlist_menuitem branch from 8b3383b to aed7f51 Compare August 19, 2024 03:25
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 5, 2025
kanda999
kanda999 approved these changes Jan 6, 2025
View reviewed changes
Copy link

@kanda999 kanda999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test: It works as expected.

@nobuQuartile nobuQuartile force-pushed the 15.0-add-website_sale_wishlist_menuitem branch 2 times, most recently from 74b7897 to 8d69235 Compare January 6, 2025 07:28
@nobuQuartile nobuQuartile force-pushed the 15.0-add-website_sale_wishlist_menuitem branch from 8d69235 to 43a8c11 Compare January 6, 2025 07:35
@yostashiro
Copy link
Member

@OCA/e-commerce-maintainers Could this one be merged?

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanda999 kanda999 kanda999 approved these changes

@JordiMForgeFlow JordiMForgeFlow JordiMForgeFlow approved these changes

@yostashiro yostashiro yostashiro approved these changes

@Highcooley Highcooley Highcooley approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AungKoKoLin1997 @OCA-git-bot @yostashiro @Highcooley @JordiMForgeFlow @kanda999