Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] website_sale_checkout_skip_payment: modify xpath to new core ch… #878

Conversation

Pablocce
Copy link

@Pablocce Pablocce commented Dec 5, 2023

Previously, a modification was made to a view in the website_sale module within the core.

Commit --> odoo/odoo#144232

The issue arises when in our module, we make our XPath query to this 'if' statement that no longer matches.

image

@pedrobaeza
Copy link
Member

Please cherry-pick #877 instead

@Pablocce Pablocce closed this Dec 5, 2023
@Pablocce Pablocce force-pushed the 16.0-fix-website_sale_checkout_skip_payment branch from 0e4a03e to 7681fc1 Compare December 5, 2023 08:46
@Pablocce Pablocce reopened this Dec 5, 2023
@Pablocce
Copy link
Author

Pablocce commented Dec 5, 2023

Done, @pedrobaeza.

I apologize for closing and reopening the Pull Request.

@Pablocce Pablocce marked this pull request as ready for review December 5, 2023 09:04
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-878-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 791cc12 into OCA:16.0 Dec 5, 2023
8 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c6dd746. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants