[18.0][MIG] website_sale_product_attribute_value_filter_existing: Migration to 18.0 #978
Conversation
pilarvargas-tecnativa
force-pushed
the
18.0-mig-website_sale_product_attribute_value_filter_existing
branch
from
4064d94 to
7d06b7d
Compare
… to 15.0 [UPD] Update website_sale_product_attribute_value_filter_existing.pot
…nature match the function signature of shop with the original one from website_sale, to avoid potential issues with other modules overwriting the function and passing unexpected parameters
pilarvargas-tecnativa
force-pushed
the
18.0-mig-website_sale_product_attribute_value_filter_existing
branch
from
7d06b7d to
34bf7ec
Compare
pilarvargas-tecnativa
force-pushed
the
18.0-mig-website_sale_product_attribute_value_filter_existing
branch
2 times, most recently
from
6cd4ff0 to
6a29eb2
Compare
…to check the real functionality of the module TT45590
…ormance improvement - Switch to setUpClass for avoiding repeat the same setup for each test. - Include context keys for avoiding mail operations overhead.
…er extraction in mobile view
…ibute parent container If only the attribute container is hidden, the parent container still occupies a space that is visible in the attribute list. To avoid this, apply the condition to the parent container and hide it completely. TT50704
pilarvargas-tecnativa
force-pushed
the
18.0-mig-website_sale_product_attribute_value_filter_existing
branch
from
6a29eb2 to
e046c79
Compare
|
/ocabot migration website_sale_product_attribute_value_filter_existing |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at ecf4bd0. Thanks a lot for contributing to OCA. ❤️ |
pedrobaeza
deleted the
18.0-mig-website_sale_product_attribute_value_filter_existing
branch
|
@pilarvargas-tecnativa Thanks for your work on updating this website_sale_product_attribute_value_filter_existing module ! I'm trying to retrofit the v18 version to a 17.4 as I cannot update our database yet and I'm facing this exact problem All possible values for a given attribute are displayed in front end filters even though only 2 or 3 are used on actual displayed product, which is nonsensical for eCommerce This is very explicit for the Brand attribute for example, and should be standard IMO. Why display "Category A's brands" when looking at Category B Would you have any input on how to do that retrofit, as the v17 version of this module was skipped 🙂? I can import the module but then I suppose I end up with an empty attr_values_used because only the names of my attributes are displayed. Tried to tweak it a bit with ChatGPT as I am not a dev at all but without any success unfortunately Many thanks Eliott |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
cc @Tecnativa TT51372
@CarlosRoca13 @chienandalu please review