Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][ADD] website_sale_order_cancel: New module website_sale_order_cancel #994

Open
wants to merge 1 commit into
base: 15.0
Choose a base branch
from

Conversation

ppyczko
Copy link

@ppyczko ppyczko commented Dec 9, 2024

This module allows customers to cancel confirmed sales orders directly from the Odoo portal using a simple confirmation modal. The sale order cannot be cancelled if it has any validated related stock pickings.

cc https://github.com/APSL 164428

@miquelalzanillas @lbarry-apsl @mpascuall @peluko00 @javierobcn @BernatObrador please review

@ppyczko ppyczko marked this pull request as draft December 9, 2024 12:37
@ppyczko ppyczko force-pushed the 15.0-add-website_sale_order_cancel branch 7 times, most recently from c7c258d to 0b82494 Compare December 10, 2024 08:09
@ppyczko
Copy link
Author

ppyczko commented Dec 10, 2024

Hi @pedrobaeza @chienandalu, sorry to bother you. I'm facing an issue with the tour and I can't get the tests to pass. Do you have any suggestions or ideas on how to resolve this? I’d really appreciate your help. Thank you!

The error in question: https://github.com/OCA/e-commerce/actions/runs/12251915314/job/34177467304?pr=994#step:8:2487

@pedrobaeza
Copy link
Member

Sorry, I can't help in this.

@ppyczko ppyczko force-pushed the 15.0-add-website_sale_order_cancel branch from 0b82494 to a23c1af Compare December 10, 2024 15:09
@ppyczko
Copy link
Author

ppyczko commented Dec 10, 2024

Sorry, I can't help in this.

Thank you @pedrobaeza anyways, finally figured it out. I was following this guide and, in the Python section, it says you have to specify 'your_module.your_tour_name':

imagen

Well, removing 'your_module' was enough to solve it, kinda misleading. 😅
Thank you for your time!

@ppyczko ppyczko marked this pull request as ready for review December 10, 2024 15:34
@pedrobaeza pedrobaeza added this to the 15.0 milestone Dec 10, 2024
Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

Copy link

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat and code review

@ppyczko ppyczko force-pushed the 15.0-add-website_sale_order_cancel branch from a23c1af to 69c6486 Compare December 11, 2024 11:40
@ppyczko ppyczko force-pushed the 15.0-add-website_sale_order_cancel branch from 69c6486 to cc8f5ae Compare December 17, 2024 14:28
Copy link

@BernatObrador BernatObrador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants