17.0 [MIG] fieldservice_sale #1151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[IMP] Remove Duplicate Field
Added ability to link a product with FSM order template and create FSM orders upon sale order confirmation Added option to install fieldservice_sale module
Added support for selling recurring orders
Travis Typo, wrong model relationship Improved values prepation method for recurring Updated errors on SO smart button for recurring
- Completed field service orders will now update the qty_delivered field on linked SO line
- suggestions from reviewer comments
- This change will allow to create an FSM order for each sales order and link it to the delivery order and invoice
- Combine field service template info from sale order lines and add it to field service order
Consumable and Storable product types were not generating field services
- Was not calling super properly and FSM orders on the sale line that were not recurring orders were not being created. - Delete unused computed field.
dreispt
reviewed
Dec 28, 2023
| lambda l: l.product_id.field_service_tracking == "sale" | ||
| and not l.fsm_order_id | ||
| lambda L: L.product_id.field_service_tracking == "sale" | ||
| and not L.fsm_order_id |
There was a problem hiding this comment.
Why the uppercase? Convention is to use lowercase variable names.
There was a problem hiding this comment.
Why the uppercase? Convention is to use lowercase variable names.
With the lowecase I got an error regarding "ambiguous variable name". I got the suggestion to change from l to L from here: https://docs.astral.sh/ruff/rules/ambiguous-variable-name/
…vice into 17.0-imp-v17-style-icon
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: field-service-17.0/field-service-17.0-fieldservice_route Translate-URL: https://translation.odoo-community.org/projects/field-service-17-0/field-service-17-0-fieldservice_route/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: field-service-17.0/field-service-17.0-base_territory Translate-URL: https://translation.odoo-community.org/projects/field-service-17-0/field-service-17-0-base_territory/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: field-service-17.0/field-service-17.0-fieldservice Translate-URL: https://translation.odoo-community.org/projects/field-service-17-0/field-service-17-0-fieldservice/
Currently translated at 100.0% (12 of 12 strings) Translation: field-service-17.0/field-service-17.0-fieldservice_account Translate-URL: https://translation.odoo-community.org/projects/field-service-17-0/field-service-17-0-fieldservice_account/it/
Currently translated at 100.0% (564 of 564 strings) Translation: field-service-17.0/field-service-17.0-fieldservice Translate-URL: https://translation.odoo-community.org/projects/field-service-17-0/field-service-17-0-fieldservice/es/
…service into 17.0-mig-fieldservice_sale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@max3903 @brian10048